Skip to content

Commit

Permalink
fix MockMonitor reporting DeletedWith wasn't supported (#1236)
Browse files Browse the repository at this point in the history
# Description

Make sure the mockmonitor works the same way as the other SDKs as
changed in pulumi/pulumi#14118 and
pulumi/pulumi-dotnet#184.

## Checklist

<!--- Please provide details if the checkbox below is to be left
unchecked. -->
- [ ] I have added tests that prove my fix is effective or that my
feature works
<!--- 
User-facing changes require a CHANGELOG entry.
-->
- [x] I have updated the
[CHANGELOG-PENDING](https://github.com/pulumi/pulumi/blob/master/CHANGELOG_PENDING.md)
file with my change
<!--
If the change(s) in this PR is a modification of an existing call to the
Pulumi Service,
then the service should honor older versions of the CLI where this
change would not exist.
You must then bump the API version in
/pkg/backend/httpstate/client/api.go, as well as add
it to the service.
-->
- [ ] Yes, there are changes in this PR that warrants bumping the Pulumi
Service API version
<!-- @pulumi employees: If yes, you must submit corresponding changes in
the service repo. -->
  • Loading branch information
Zaid-Ajaj authored Oct 9, 2023
2 parents ba91245 + 511d353 commit 353d99a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion CHANGELOG_PENDING.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,5 @@
### Bug Fixes

- Fixes `builder()` implementation for result types where the identifier of the local variable defined for the result type collides with one of the fields of the result type.
- Adds `options.encoding = "UTF-8"` to the `compileJava` options so that it can handle non-ASCII characters in the source code, especially in the documentation comments of fields.
- Adds `options.encoding = "UTF-8"` to the `compileJava` options so that it can handle non-ASCII characters in the source code, especially in the documentation comments of fields.
- Fixes MockMonitor reporting DeletedWith wasn't supported
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public MockMonitor(Mocks mocks, Log log) {

@Override
public CompletableFuture<SupportsFeatureResponse> supportsFeatureAsync(SupportsFeatureRequest request) {
var hasSupport = "secrets".equals(request.getId()) || "resourceReferences".equals(request.getId());
var hasSupport = !"outputValues".equals(request.getId());
return CompletableFuture.completedFuture(
SupportsFeatureResponse.newBuilder().setHasSupport(hasSupport).build()
);
Expand Down

0 comments on commit 353d99a

Please sign in to comment.