Allow specifiying dependencies for output invokes #1482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienp
force-pushed
the
julienp/depends-on
branch
from
d2e01cd
to
eb8fc84
Compare
julienp
commented
Nov 25, 2024
| @@ -17,7 +17,7 @@ | |||
| * Options to help control the behavior of @see {@link Deployment#invokeAsync(String, TypeShape, InvokeArgs, InvokeOptions)}. | |||
| */ | |||
| @ParametersAreNonnullByDefault | |||
| public final class InvokeOptions { | |||
| public class InvokeOptions { | |||
There was a problem hiding this comment.
I want InvokeOutputOptions to inherit from this, do we care about this being final?
julienp
commented
Nov 26, 2024
| } | ||
|
|
||
| @Test | ||
| void testInvokesDependsOn() { |
There was a problem hiding this comment.
We have a unit test here, but the language conformance test l2-invoke-options-depends-on is not enabled yet. I spent some time trying to fix program gen to generate something usable, but haven't completed that work yet. The way we generate lambdas is broken, and requires work.
julienp
force-pushed
the
julienp/depends-on
branch
from
48ba484
to
ec37d0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provider functions that take inputs as arguments, and return an output (aka output form invokes), now allow specifying a depends_on option. This allows programs to ensure that invokes are executed after things they depend on, similar to the depdends_on resource option.
Fixes pulumi/pulumi#17754