Inline runner machinery #1616
Open
Inline runner machinery #1616
+221
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikhailshilkov
added
the
impact/no-changelog-required
justinvp
reviewed
Jan 31, 2025
| public static DeploymentImpl fromInline(InlineDeploymentSettings settings) { | ||
| var state = DeploymentState.fromInline(settings); | ||
| var impl = new DeploymentImpl(state); | ||
| DeploymentInstanceHolder.setInstance(new DeploymentInstanceInternal(impl)); |
There was a problem hiding this comment.
Have you tried multiple calls to Construct within the same process (e.g. creating two separate instances of an MLC from the Pulumi program)?
I am hitting the following when I have multiple operations that involve the inline program (e.g. a preview and up) in the same process:
I haven't dug in to see if/how .NET avoids it.
There was a problem hiding this comment.
I confirm I can see the same, thank you. .NET seems to work fine - I'll dig further.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use case is to be able to create resources without an arbitrary function that is created inside a provider (
Constructin particular). All methods are marked internal and are intended to be consumed from our own SDK.Based on our .NET implementation in https://github.com/pulumi/pulumi-dotnet/tree/main/sdk/Pulumi/Deployment
Towards #1335
No testing yet - but opening it up also for @justinvp to take a look in case there may be any overlap with Automation API work.