Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment resource secret regression #442

Closed
IaroslavTitov opened this issue Nov 14, 2024 · 0 comments · Fixed by #443
Closed

Environment resource secret regression #442

IaroslavTitov opened this issue Nov 14, 2024 · 0 comments · Fixed by #443
Assignees
Labels
kind/bug Some behavior is incorrect or out of spec p1 A bug severe enough to be the next item assigned to an engineer resolution/fixed This issue was fixed
Milestone

Comments

@IaroslavTitov
Copy link
Contributor

What happened?

The outputs of Check method show plaintext secrets on diff. Need to fix.

Example

const my_super_secret_yaml = new pulumi.asset.StringAsset(
  `values:
    superSecret: SECRET`
    )

const withoutSecret = new service.Environment("modular test env", {
  name: "test",
  organization: "yoba",
  project: "test",
  yaml: my_super_secret_yaml,
});

Output of pulumi about

Not relevant

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@IaroslavTitov IaroslavTitov added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Nov 14, 2024
@IaroslavTitov IaroslavTitov self-assigned this Nov 14, 2024
@IaroslavTitov IaroslavTitov added p1 A bug severe enough to be the next item assigned to an engineer and removed needs-triage Needs attention from the triage team labels Nov 14, 2024
@IaroslavTitov IaroslavTitov added this to the 0.113 milestone Nov 14, 2024
@komalali komalali added the resolution/fixed This issue was fixed label Nov 18, 2024
@komalali komalali linked a pull request Nov 18, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Some behavior is incorrect or out of spec p1 A bug severe enough to be the next item assigned to an engineer resolution/fixed This issue was fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants