Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed secrets shown in diff #443

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Fixed secrets shown in diff #443

merged 1 commit into from
Nov 14, 2024

Conversation

IaroslavTitov
Copy link
Contributor

Summary

  • Made sure Check method uses secrets and correctly keeps them in place. Yaml field is forced into a secret at all times.

Testing

  • Manual test

@IaroslavTitov IaroslavTitov marked this pull request as ready for review November 14, 2024 22:15
@IaroslavTitov IaroslavTitov merged commit f01dd75 into main Nov 14, 2024
14 checks passed
@IaroslavTitov IaroslavTitov deleted the iaro/fix branch November 14, 2024 23:03
@komalali komalali linked an issue Nov 18, 2024 that may be closed by this pull request
Environment resource secret regression #442
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanyeh seanyeh seanyeh approved these changes

@komalali komalali komalali approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Environment resource secret regression
3 participants
@IaroslavTitov @seanyeh @komalali