Fixing refresh breaking drift and ttl schedule #260
Conversation
|
PR checks are failing, so I made #261 to fix the wf |
### Summary - The main build and test workflow has been failing for my PRs: - #259 - #260 - As far as I understood the issue, some dependency now leaves a folder called `go` with this in it: ``` go/pkg/mod/cache/download/github.com/pulumi/pulumi/pkg/v3/@v: list v3.112.0.info v3.112.0.mod ``` I just set to ignore it in .gitignore, is there a better solution maybe? I figured it was not worth tracking down where it comes from, since this looks like some package metadata, lmk if we care to find out what leaves that behind. Also: - Adding '.mono` to gitignore, dotnet compilation keeps generating it - Adding logic to not install not needed languages, which speeds up tests a little
| if i.AutoRemediate != nil { | ||
| propertyMap["autoRemediate"] = resource.NewPropertyValue(*i.AutoRemediate) | ||
| } |
There was a problem hiding this comment.
You shouldn't have to do this. Instead, you can set a default in the schema like some properties in deploymentSettings.
There was a problem hiding this comment.
Good point, didn't realize default values existed in schema. Updated the PR to use default values, but sadly then had to adjust Diff logic, as it turns out in Diff's GetNews() doesn't provide default values, so second and beyond pulumi up would always show diffs
There was a problem hiding this comment.
Huh, I find that surprising. We use a similar pattern in deploymentSettings and don't have to do this in the diff function. Looking at the generated SDKs it would be very surprising if this didn't work since they all provide the defaults if they're not specified. Which SDK were you testing with?
There was a problem hiding this comment.
Wondering if maybe the SDK wasn't regen'd before you tested.
There was a problem hiding this comment.
I used Dotnet SDK
I ran pulumi up on schedules without the booleans, and they were filled with false successfully (indicating that the schema change worked), but when I ran pulumi up again it showed the diff.
I will try to clean SDK and regenerate to make sure before I merge, just in case
There was a problem hiding this comment.
Confirmed by cleaning SDK, building this branch -> no change in diff, then removed explicit setting to false -> diff shows up. Sounds kind of like a bug
Summary
Testing