Added examples on how to use schedules #272
Conversation
IaroslavTitov
added
the
impact/no-changelog-required
IaroslavTitov
force-pushed
the
iaro/example
branch
10 times, most recently
from
d3e6c84 to
ea2b9ac
Compare
|
@IaroslavTitov I just made a change to the service that now validates if the stack has deployment settings and returns an error if it doesn't. So you may need to update these tests to also include deployment setting resources. |
IaroslavTitov
force-pushed
the
iaro/example
branch
4 times, most recently
from
fec0ddb to
f532a26
Compare
| Organization = "service-provider-test-org", | ||
| Project = "cs-schedules", | ||
| Stack = "test-stack", |
There was a problem hiding this comment.
You can use the output from deployment settings as an input here to create the dependency chain to ensure that the schedules are always created after the settings.
| Organization = "service-provider-test-org", | |
| Project = "cs-schedules", | |
| Stack = "test-stack", | |
| Organization = settings.Organization, | |
| Project = settings.Project, | |
| Stack = settings.Stack, |
The alternative is to add a dependsOn, but IMO this is cleaner.
There was a problem hiding this comment.
Yeah, I used dependsOn below to make dependency explicit, and mentioned it above in comment to explain to the reader.
I can do the settings properties too, agree that it's cleaner. However, in this case, since it's an example I think explicitly showing dependency is better, but can change, don't mind either way
There was a problem hiding this comment.
Ah whoops I see it now. Fine to leave as-is.
| Organization = "service-provider-test-org", | ||
| Project = "cs-schedules", | ||
| Stack = "test-stack", |
There was a problem hiding this comment.
Same idea everywhere below
| Organization = "service-provider-test-org", | |
| Project = "cs-schedules", | |
| Stack = "test-stack", | |
| Organization = settings.Organization, | |
| Project = settings.Project, | |
| Stack = settings.Stack, |
Summary
Testing