Adding revision to Environment resource #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
komalali
reviewed
May 30, 2024
| @@ -14,14 +14,26 @@ import ( | |||
| "github.com/stretchr/testify/assert" | |||
| ) | |||
|
|
|||
| type getEnvironmentFunc func(ctx context.Context, orgName string, envName string, decrypt bool) (yaml []byte, etag string, err error) | |||
| type getEnvironmentFunc func(ctx context.Context, orgName string, envName string, version string, decrypt bool) (yaml []byte, etag string, revision int, err error) | |||
There was a problem hiding this comment.
This function has to match the signature of GetEnvironment method inside ESC client. I bumped the version and signature of the method changed, so had to change to match as well.
Other than that, version allows to pass in either tag or revision that you want to get of this environment.
komalali
reviewed
May 30, 2024
| @@ -70,9 +74,11 @@ export class Environment extends pulumi.CustomResource { | |||
| resourceInputs["name"] = args ? args.name : undefined; | |||
| resourceInputs["organization"] = args ? args.organization : undefined; | |||
| resourceInputs["yaml"] = args ? args.yaml : undefined; | |||
| resourceInputs["revision"] = undefined /*out*/; | |||
There was a problem hiding this comment.
This is odd... why is it in the inputs section?
There was a problem hiding this comment.
I think this is fine, I'm just not used to seeing outputs only.
There was a problem hiding this comment.
I'm guessing because it's an output only property?
komalali
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing