This repository has been archived by the owner on Feb 18, 2022. It is now read-only.
Update PDK, spec tests, and docs #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ran `pdk convert` to get this udpated to the current version of the PDK - Updated metadata.json to allow Puppet 6 - Fixed open-ended module requirements per `pdk validate` - Fixed parameter ordering per `pdk validate` - Added `.sync.yml`
- Updated the readme to reference REFERENCE.md - Added badges to the readme - Moved documentaion from the readme to `init.pp` - Added basic docs to `windows_certificate.pp` - Generated REFERENCE.md - Removed top-scope from fact references and changed to structured facts
|
@jonnytdevops I saw you had an open branch on this repo too... this PR includes a similar fix to what you had done but uses formal facts from the Puppet Agent instead. As a result, I just wanted to put this on your radar. |
|
In contrast to #2, this PR does not make a parameter available to set the conf dir. It instead pulls it from the agent. |
|
Also, I updated the labels in this repo to match what's expected by the changelog generator. |
/cdn.vox-cdn.com/uploads/chorus_asset/file/15979212/Clippy_ShipIt.gif)
|
@glennsarti @genebean The fact used in this PR assumes the use of the puppet-agent module, which isn't something we're in a position to immediately deploy on user workstations. So that we can pin to a production SHA, I'd be grateful if another approach was used. |
genebean
added a commit
that referenced
this pull request
Apr 3, 2019
PR #1 put to use facts that I mistakenly thought came from the Puppet agent itself. This commit documents that those facts instead are provided by puppetlabs-puppet_agent via https://github.com/puppetlabs/puppetlabs-puppet_agent/blob/master/lib/facter/settings.rb
|
See notes in #3 regarding @jonnytdevops points. |
joshcooper
reviewed
Apr 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pdk convertto get this udpated to the current version of the PDKpdk validatepdk validate.sync.ymlinit.ppwindows_certificate.pp