(CAT-1868) - Remove .rspec.erb #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the .rspec.erb file from the pdk-templates, and thus the .rspec file from being managed by PDK. This was made possible due to the changes found in puppetlabs/puppetlabs_spec_helper#452. This has minimal impact on users as the file was not configurable through .sync.yml before (other than to set as unmanaged), existing modules with the .rspec will not be affected and new modules created will simply not include an .rspec file.
jordanbreen28
force-pushed
the
cat-1868-remove-rspec.erb
branch
from
70f15ef to
382f665
Compare
|
labelling as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the .rspec.erb file from the pdk-templates, and thus the .rspec file from being managed by PDK. This was made possible due to the changes found in puppetlabs/puppetlabs_spec_helper#452.
This has minimal impact on users as the file was not configurable through .sync.yml before (other than to set as unmanaged), for existing modules with the .rspec it will not be removed and new modules created will simply not include the file.
Additional Context
puppetlabs/puppetlabs_spec_helper#452.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist