(CAT-2286) Remove puppet 7 infrastructure #285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Puppet 7 is EOL. Therefore, we can remove the test infrastructure for it. This commit aims to clear up any testing/config infrastructure related to Puppet 7 and, by extension, Ruby 2.7. Bumping rubocop TargetRubyVersion to 3.1 and applying safe autocorrections.
| when Array | ||
| { cloud: cloud, region: region, zone: zone, images: platform } | ||
| { cloud:, region:, zone:, images: platform } |
There was a problem hiding this comment.
yep, thats Ruby's 3.1+ recommended syntax. Rubocop safely autocorrected it
david22swan
approved these changes
Apr 16, 2025
shubhamshinde360
added a commit
to puppetlabs/puppetlabs-mysql
that referenced
this pull request
Apr 18, 2025
ubuntu-20.04 is not supported anymore: actions/runner-images#11101 Fixed a rubocop offense. Upgraded ruby to 3.1 since there is some syntax introduced in puppetlabs/provision#285 which is only compatible with ruby 3.1+.
shubhamshinde360
added a commit
to puppetlabs/puppetlabs-mysql
that referenced
this pull request
Apr 18, 2025
ubuntu-20.04 is not supported anymore: actions/runner-images#11101 Fixed a rubocop offense. Upgraded ruby to 3.1 since there is some syntax introduced in puppetlabs/provision#285 which is only compatible with ruby 3.1+.
shubhamshinde360
added a commit
to puppetlabs/puppetlabs-mysql
that referenced
this pull request
Apr 18, 2025
ubuntu-20.04 is not supported anymore: actions/runner-images#11101 Fixed a rubocop offense. Upgraded ruby to 3.1 since there is some syntax introduced in puppetlabs/provision#285 which is only compatible with ruby 3.1+.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Puppet 7 is EOL. Therefore, we can remove the test infrastructure for it. This commit aims to clear up any testing/config infrastructure related to Puppet 7 and, by extension, Ruby 2.7. Bumping rubocop TargetRubyVersion to 3.1 and applying safe autocorrections.