(MAINT) SSL Verification extended #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed SSL verification mode to VERIFY_PEER for enhanced security. - Added Puppet settings initialization to load necessary certificates. - Updated HTTP request to use Puppet's certname and certificate files. - Ensured CA file is set for SSL verification.
- Fixed incorrect syntax in Net::HTTP initialization. - Corrected method calls for SSL setup and certificate handling. - Ensured proper request initialization for RBAC token generation.
- Fixed incorrect reference to Net::HTTPSuccess class in token request error handling.
Corrected the typo in the initialization of Net::HTTP::Post for creating the RBAC token request. This ensures the correct HTTP method is used for the request.
…TTPS connection Changed the HTTPS connection to use Puppet's certname instead of 'localhost' to ensure proper SSL certificate validation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
Changes include test coverage?
Have you updated the documentation?