Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) Run pdk update with version 3.4.0 and fix sync.yml with the pdk #530

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jhbuchanan45
Copy link
Contributor

Summary

The yamlformatter action broke the sync.yml for the pdk.

Additional Context

The yamlformatter action automatically changes all yaml files we commit to be a standard format, including no 'quotes' around key names. (see the attached diff for an example). While both of these files are valid YAML officially, ruby's yaml parser apparently treats keys starting with ':' as symbols, which aren't an allowed class by YAML.safe_load by default, leading to a Psych error from the PDK.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.

Changes include test coverage?

  • Yes
  • Not needed

Have you updated the documentation?

  • Yes, I've updated the appropriate docs
  • Not needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant