Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Bug): do not pass dsc_timeout as timeout parameter to DSC resource params #366

Merged
merged 2 commits into from
Feb 14, 2025

Conversation

jordanbreen28
Copy link
Contributor

@jordanbreen28 jordanbreen28 commented Feb 14, 2025

Summary

Provide a detailed description of all the changes present in this pull request.

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Supersedes #359

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.09%. Comparing base (c45001a) to head (87fc0e2).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #366      +/-   ##
==========================================
+ Coverage   92.08%   92.09%   +0.01%     
==========================================
  Files           6        6              
  Lines         720      721       +1     
==========================================
+ Hits          663      664       +1     
  Misses         57       57              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jordanbreen28 jordanbreen28 marked this pull request as ready for review February 14, 2025 12:23
@jordanbreen28 jordanbreen28 requested a review from a team as a code owner February 14, 2025 12:23
@jordanbreen28 jordanbreen28 changed the title Bug fix dsc timeout (Bug): fix dsc timeout Feb 14, 2025
@jordanbreen28 jordanbreen28 changed the title (Bug): fix dsc timeout (Bug): do not pass dsc_timeout as timeout parameter to DSC resource params Feb 14, 2025
@pmcmaw pmcmaw merged commit 3c4af88 into main Feb 14, 2025
8 checks passed
@pmcmaw pmcmaw deleted the bug-fix_dsc_timeout branch February 14, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants