Speed up the landing page #204
Conversation
|
https://www.vexforum.com/t/the-pros-of-pros/59425/14?u=ranchsauce Another testimonial (though do note it's from theo lol) |
|
By the way, I feel like we should notify those who we are using testimonials of in some capacity or another that we are using their quotes on our webpage. |
|
I like your post from Theo best, let's go with that one. I can reach out to him and Oscar on discord to get their permission to use the testimonials. |
|
Both Theo and Oscar are cool with the quotes, I'll update the PR with them in a bit. |
|
So here are the two best photo candidates I could find for the PROS photo... They're all from 2017 though and not great candidates hahaha It seems like we're not getting much from the request for photos in our discord so it might be time to strike that section from the draft |
|
Honestly, the first picture would probably be the better of the two candidates. However, another good alternative to this is to put the picture of Purdue that we already have in that spot. |
|
I tried using the Purdue picture but it seemed a bit empty, was best off as a background image. I pulled the header image from this article about the tournament (https://www.cs.purdue.edu/news/articles/2019/SIGBots-2019.html), thoughts?
|
|
Oh yeah that looks better for sure, good with me 👍 |
|
@kunwarsahni01 @HotelCalifornia This PR should be ready to go so long as it's good with you, can you add your reviews whenever you get a chance? |
|
Any chance we could re-record the gif in the background with the latest API? if not it's whatever |
|
also maybe as a side project, set up auto-deploy forCI build artifacts from PRs to a staging URL so the results can be verified online (: |
It would be possible but I don't have a Windows machine up and running at the moment, would need someone else to update the GIF with the PROS editor. We could open a separate issue for that here and get around to it eventually maybe?
I would love to see that happen, not really sure what all we have in the way of a staging domain though. My first thought was to use github pages or something similar, could we do this with the existing azure-pipelines setup though? |
my initial thought was to set up a branch on this repo for gh-pages to use and then have the pipeline commit the artifacts there under a folder keyed to the PR so you'd be able to get to the build for a PR at https://purduesigbots.github.io/pros-docs/204/ or something. i'm sure there's a way to do this in azure, but failing all else i have some sample github workflows we might be able to adapt |
|
Opened #214 for this, can take a look at that sometime this week |
|
Kunwar's suggestions from Discord:
|
|
I merged master in, updated a couple of things (like mentioning VSCode instead of Atom), and updated the screenshots in the PR description. For some added context on why I'd really like to merge this in, here's how the current webpage renders (after some time) on my machine:
|
|
Testing this locally on a mac and looks like the download and getting started buttons link to the same page? Also looks like every time I reload the webpage locally the entire site starts drifting to the left more and more. |
|
Thanks for the feedback, I also realized that those download/getting started links go to the old, pre-VSC docs. Updates those to match the current stuff |
There was a problem hiding this comment.
@kunwarsahni01 Our front page needs a bit of a touchup, let's get this done.
Moving away from Bootstrap and the old template to a simple CSS file and no JS. Kept the home page mostly the same, but added a couple of new items too.
Lighthouse scores (on localhost)
Screenshots:
Desktop
Mobile
