Remove sexp-show handling code
#44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out this file wasn't in the build system and was causing a lot of warnings upon compilation. Further digging into what is that it does revealed it is a code for handling `sexp-show` from Hackage to do some Show-related edits in the buffer. However, it ain't clear how it's supposed to work (sexp-show just hangs when invoked with --help) and if it's even useful for PureScript (the file was part of the haskell-mode codebase when the project was forked). Original haskell-mode removed this code in 2015 here haskell/haskell-mode#616 with commentary: > It requires the sexp-show package (which hasn't been updated since 2012 > and was abandoned in 2014) to be installed from Hackage to work. > However, even if it's customization option is enabled it doesn't > actually seem to be used/called anywhere, making it less than useful. > > Closes #615 Let's follow the trend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out this file wasn't in the build system and was causing a lot of warnings upon compilation. Further digging into what is that it does revealed it is a code for handling
sexp-showfrom Hackage to do some Show-related edits in the buffer. However, it ain't clear how it's supposed to work (sexp-show just hangs when invoked with --help) and if it's even useful for PureScript (the file was part of the haskell-mode codebase when the project was forked).Original haskell-mode removed this code in 2015 here haskell/haskell-mode#616 with commentary:
Let's follow the trend.