add MonadThrow MonadError instances for Effect

[safareli]

No description provided.

[hdgarrood]

LGTM, although it might be worth checking that adding the exceptions dependency doesn't have any unintended consequences. @garyb, any thoughts on that?

[garyb]

Seems ok to me - I think it's only be a problem if we had a circular dependency. Technically it maybe should be a breaking change, but realistically this wouldn't be the first time we added a core library dependency to another core library and didn't call it breaking, especially when it's super commonly already going to be there anyway.

[safareli]

Great! (feel free to do squish merge, I was lazy and used web editor of github for this pr, hence this many commits :D)

[hdgarrood]

Wait, I thought our policy was that a dependency change is only considered breaking if a dependency is being removed (because you can pull things in via transitive dependencies and not mention them explicitly in your local bower.json file)?

[garyb]

Additions can hypothetically break too:

• A depends on B and C
• B depends on D v1
• C adds a dependency for D v2 and only minor-bumps
• Installing the most up to date dependencies for A would now fail

[hdgarrood]

Aren't solvers supposed to deal with situations like that - in this case, by taking the older version of C? (Admittedly Bower doesn't really have one...)

[garyb]

Yeah I guess so, but also yeah Bower doesn't solve 😉

[safareli]

in this case tho, ps-exceptions v4 is published with [email protected] version so older version can't be used anyway (I guess)