Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAPP-2007 Replaced x.com/pushprotocol with x.com/PushChain #2008

Conversation

rohitmalhotra1420
Copy link
Collaborator

@rohitmalhotra1420 rohitmalhotra1420 commented Jan 29, 2025

Pull Request Template

Ticket Number

Description

Replaced x.com/pushprotocol with x.com/PushChain

  • Problem/Feature:

Type of Change

  • Bug fix
  • New feature
  • Code refactor
  • Documentation update
  • Other (please describe):

Checklist

  • Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
    • Quick PR label added
  • Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
    • DO NOT Merge PR label added

Frontend Guidelines

Build & Testing

  • No errors in the build terminal
  • Engineer has tested the changes on their local environment
  • Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

  • Before: Explain the previous behavior

  • After: What's changed now

Additional Context

Review & Approvals

  • Self-review completed
  • Code review by at least one other engineer
  • Documentation updates if applicable

Notes

@rohitmalhotra1420 rohitmalhotra1420 self-assigned this Jan 29, 2025
Copy link

File: README.md

  1. In the <h1> tag, the closing tag </h1> is missing, it should be added after the <img> tags.
  2. The <i> tag for the Push Protocol description is deprecated. Consider using <em> or <span> with appropriate styling instead.
  3. Inside the Modules section:
    • There is a missing closing <a> tag for the Twitter link under the Alias section.
    • The closing tags for the <details> sections are missing.
  4. In the Installation section, the command to change to the project directory should be within a code block.
  5. The note under the Installation section has a typo, it should be 'Make sure to generate the .env file...'
  6. In the Contributing section, the link to the contributing.md file is broken. It should be fixed.
  7. Avoid using outdated or incorrect URLs like "https://x.com/PushChain" or broken image links.
  8. Minor typo in the sentence 'Ensure the user has at-least 50 Followers and is following', it should be 'Ensure the user has at least 50 followers and is following'.

All looks good.

Copy link

github-actions bot commented Jan 29, 2025

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2025-01-31 12:22 UTC

@rohitmalhotra1420 rohitmalhotra1420 merged commit 4cbd33c into main Jan 31, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant