DAPP-2005: PGP Key feature in channels #2009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added Unlock Profile modal to enforce profile unlocking before any channel action. - Updated SDK function to allow channel actions without requiring signer approval each time. - Fixed device config issue in Tooltip and Unlock Profile component.
|
All looks good. |
|
rohitmalhotra1420
requested changes
Jan 30, 2025
| } | ||
| }, [profileModalVisibility, userPushSDKInstance]); | ||
|
|
||
| const optInHandler = useCallback( |
There was a problem hiding this comment.
remove useCallback
package.json
Outdated
| @@ -34,7 +34,7 @@ | |||
| "@metamask/eth-sig-util": "^4.0.0", | |||
| "@mui/icons-material": "^5.8.4", | |||
| "@mui/material": "^5.5.0", | |||
| "@pushprotocol/restapi": "1.7.29", | |||
| "@pushprotocol/restapi": "1.7.30-exp.3", | |||
There was a problem hiding this comment.
add the stable release version here
|
All looks good. |
|
All looks good. |
rohitmalhotra1420
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DAPP-2005
Description
Notion Documentation: Doc link