Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile with rollup for smaller build sizes #27

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

peterpme
Copy link
Collaborator

@peterpme peterpme commented May 7, 2017

Build dist files when publishing:

  • Remove standalone.min.js
  • Remove lib

We no longer have to worry about these files when working with React AB Test. It'll make PR's a little easier to manage!

@peterpme peterpme self-assigned this May 7, 2017
"loose": true
}
],
"stage-1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we need stage-1?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can use stage-2 if you prefer! It was just out of habit :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I prefer stage-3 or stage-4 as they are more stable, but It depends

@wehriam
Copy link
Contributor

wehriam commented Jun 22, 2017

@peterpme would like to merge this in if you can resolve the conflicts.

@peterpme
Copy link
Collaborator Author

Will rebase and take a look at them again in the next few days. New job, not enough time :) Thanks for staying patient!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants