Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #76, add tabindex attribute to input element #108

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ebrenes
Copy link
Contributor

@ebrenes ebrenes commented Mar 31, 2017

Fix for #76

Description

  • Added unit test for tab index
  • Added documentation
  • Added examples

Motivation and Context

Be able to set the tabindex on the datepicker to control the tab ordering in a form.

How Has This Been Tested?

Ran the unit tests and also tested it on the example application.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Added unit test for tab index
- Added documentation
- Added examples
@ebrenes ebrenes changed the title Add tabindex attribute to input element Fix for #76, add tabindex attribute to input element Mar 31, 2017
@wehriam
Copy link
Contributor

wehriam commented Jun 19, 2017

Hi @ebrenes - thanks for the PR! Please review the conflicts when you have a chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants