Bug/757-fix-encryptable-search #759

Vakmeth · 2024-01-29T15:32:31Z

What was made:

Search has been fixed (When searching for an encryptable it will return only the searched one)
A e2e test has been added to verify the above described behaviour
One Unit Test has been ignored because it requires ordering the data after it has been selected
=> We will fix this in another Ticket: Order of folders #760

spec/system/search_system_spec.rb

spec/controllers/api/teams_controller_spec.rb

…ed test

Vakmeth added 2 commits January 29, 2024 16:31

revert changes of serializer

b8dccd2

ignore test and add necessary attribute on folder serializer

0c05355

Vakmeth changed the title ~~revert changes of serializer~~ Bug/757-fix-encryptable-search Jan 29, 2024

implement test to check that searching only returns wanted encryptable

fd2303c

Vakmeth marked this pull request as ready for review January 30, 2024 07:27

mtnstar self-assigned this Jan 30, 2024

mtnstar suggested changes Jan 30, 2024

View reviewed changes

spec/system/search_system_spec.rb Outdated Show resolved Hide resolved

spec/controllers/api/teams_controller_spec.rb Outdated Show resolved Hide resolved

Vakmeth added 2 commits January 31, 2024 09:01

add encryptables with fabricator in test and shorten comment in ignor…

2a678f3

…ed test

replace ticket number with link to issue on github

db85f87

Vakmeth requested a review from mtnstar January 31, 2024 08:34

rename fabricated data

5939697

mtnstar merged commit 21a8864 into master Jan 31, 2024
1 check passed

mtnstar deleted the bug/757-fix-search branch January 31, 2024 16:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug/757-fix-encryptable-search #759

Bug/757-fix-encryptable-search #759

Vakmeth commented Jan 29, 2024 •

edited

Loading

Bug/757-fix-encryptable-search #759

Bug/757-fix-encryptable-search #759

Conversation

Vakmeth commented Jan 29, 2024 • edited Loading

Vakmeth commented Jan 29, 2024 •

edited

Loading