Feature/refactor delete #1397
Draft
Feature/refactor delete #1397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcinay055679
force-pushed
the
feature/refactor-delete
branch
from
433700f to
2741735
Compare
kcinay055679
force-pushed
the
feature/refactor-delete
branch
from
a35ff8b to
81f251c
Compare
kcinay055679
force-pushed
the
feature/refactor-delete
branch
from
81f251c to
b9da4c6
Compare
kcinay055679
force-pushed
the
feature/refactor-delete
branch
from
b9da4c6 to
08a3231
Compare
peggimann
requested changes
Feb 19, 2025
There was a problem hiding this comment.
Overall i see that this works, however i think this adds too much tech depth to the project, consider the following:
- We do not need a Hard-Delete anymore simply stay with soft-delete
- I reckon that interfacing could simplify the "Generic Hell" instead of using abstract classes
- Maybe even direct implementations are the way to go instead of abstracting that much
- Overall look over your PR there are quite some amount of unwanted comments/ todos left over.
| @@ -1,7 +1,7 @@ | |||
| <component name="ProjectRunConfigurationManager"> | |||
| <configuration default="false" name="OkrApplication-E2E" type="SpringBootApplicationConfigurationType" factoryName="Spring Boot"> | |||
| <option name="ACTIVE_PROFILES" value="integration-test" /> | |||
| <option name="ALTERNATIVE_JRE_PATH" value="$USER_HOME$/.sdkman/candidates/java/current" /> | |||
| <option name="ALTERNATIVE_JRE_PATH" value="corretto-21" /> | |||
There was a problem hiding this comment.
why? maybe sdkman works best for all
|
|
||
| @NoRepositoryBean | ||
| public interface DeleteRepository<E extends Deletable, I> extends CrudRepository<E, I>, JpaSpecificationExecutor<E> { | ||
| // @Query("select #{#entityName} e set e.isDeleted = true where e.id = :id") |
There was a problem hiding this comment.
remove comment seems unnecessary to me
|
|
||
| Integer countByTeamAndQuarter(Team team, Quarter quarter); | ||
| Integer countByTeamAndQuarterAndIsDeletedFalse(Team team, Quarter quarter); |
There was a problem hiding this comment.
is only used for testing, remove and remove tests or make separate task, up to you
| @@ -10,6 +10,7 @@ | |||
| @Documented | |||
| @Inherited | |||
| @SpringBootTest | |||
| // @DirtiesContext(classMode = DirtiesContext.ClassMode.BEFORE_CLASS) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.