Update test suite for pvlib v0.9.0 (#115)

* stop using orientation_strategy parameter * change xfail to skip
pvlib · Dec 3, 2021 · bb451a0 · bb451a0
1 parent a3d3860
commit bb451a0
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 8 deletions.
diff --git a/pvanalytics/tests/features/test_clearsky.py b/pvanalytics/tests/features/test_clearsky.py
@@ -4,7 +4,7 @@
 from pvanalytics.features import clearsky
 
 
-@pytest.mark.xfail(strict=True)
+@pytest.mark.skip(reason="GH #105")
 @pytest.mark.filterwarnings("ignore:Support for multi-dimensional indexing")
 def test_reno_identical(quadratic):
     """Identical clearsky and measured irradiance all True"""
@@ -14,7 +14,7 @@ def test_reno_identical(quadratic):
     assert clearsky.reno(quadratic, quadratic).all()
 
 
-@pytest.mark.xfail(strict=True)
+@pytest.mark.skip(reason="GH #105")
 @pytest.mark.filterwarnings("ignore:Support for multi-dimensional indexing")
 @pytest.mark.filterwarnings("ignore:invalid value encountered in")
 def test_reno_begining_end(quadratic):

diff --git a/pvanalytics/tests/features/test_orientation.py b/pvanalytics/tests/features/test_orientation.py
@@ -46,7 +46,6 @@ def power_tracking(clearsky, albuquerque, system_parameters):
     mc = modelchain.ModelChain(
         system,
         albuquerque,
-        orientation_strategy='south_at_latitude_tilt'
     )
     mc.run_model(clearsky)
     return mc.ac

diff --git a/pvanalytics/tests/test_system.py b/pvanalytics/tests/test_system.py
@@ -52,24 +52,24 @@ def summer_ghi(summer_clearsky):
 @pytest.fixture
 def summer_power_fixed(summer_clearsky, albuquerque, system_parameters):
     """Simulated power from a FIXED PVSystem in Albuquerque, NM."""
-    pv_system = pvsystem.PVSystem(**system_parameters)
+    pv_system = pvsystem.PVSystem(surface_azimuth=180,
+                                  surface_tilt=albuquerque.latitude,
+                                  **system_parameters)
     mc = modelchain.ModelChain(
         pv_system,
         albuquerque,
-        orientation_strategy='south_at_latitude_tilt'
     )
     mc.run_model(summer_clearsky)
     return mc.ac
 
 
 @pytest.fixture
 def summer_power_tracking(summer_clearsky, albuquerque, system_parameters):
-    """Simulated power for a pvlib SingleAxisTracker PVSystem in Albuquerque"""
+    """Simulated power for a TRACKING PVSystem in Albuquerque"""
     pv_system = tracking.SingleAxisTracker(**system_parameters)
     mc = modelchain.ModelChain(
         pv_system,
-        albuquerque,
-        orientation_strategy='south_at_latitude_tilt'
+        albuquerque
     )
     mc.run_model(summer_clearsky)
     return mc.ac