Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add more unit tests #1

Conversation

duttonw
Copy link

@duttonw duttonw commented Feb 26, 2025

working towards ensuring we cover all edge cases with this enhancement

dependabot-preview bot and others added 30 commits April 28, 2021 22:14
Develop to master - merge from upstream
Develop to master - make datastore more robust
- If all types have been rejected, ensure that the fallback flag is correctly set
- replace empty strings with None if they have types that will choke on empty string
- Column that has some rows with free text and others with numeric data
- Column that has some rows with timestamp and others with empty string
- Remove unused imports, or tag those that serve a purpose (testing what can be imported)
- Remove obsolete exclusions from Flake8 config
- Show the first 100 and last 100 logs, with a message between to say how many were skipped
- Start with the first and last 50 rows, provide a link to double it
- Add a notice at the top of the page when logs have been hidden.
- Clarify that we are hiding logs, not skipping actual processing of data.
- Add 'Show All' link to show all logs if the user is confident they can handle it.
[QOLSVC-1863] truncate on-page XLoader logs if there are too many
Develop to master - merge and fix upstream changes
- This is more efficient than setting it on each call,
and applies even to code that just reads the config without accepting an override.
amercader and others added 25 commits November 21, 2024 11:04
Update README, migrate it to Markdown
- Squashed version of ckan#200.
- Removed unused import.
BREAKING CHANGE: SQLAlchemy v2 is not supported in CKAN 2.9.x. CKAN 2.9.x support dropped
Fix for compatibility with CKAN Table Designer feature
duttonw added 2 commits March 3, 2025 11:03
… feature/custom-xloader-site-url_updated

 Conflicts:
	ckanext/xloader/plugin.py
@duttonw
Copy link
Author

duttonw commented Mar 3, 2025

closing as ckan#243 will handle this.

@duttonw duttonw closed this Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants