Fixed rotation in Moz/WebKit and corrected PageVisibility check #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Another option is go back to inline spans instead of inline-block, but that loses rotation in Firefox/WebKit. We only get rotation because we violate the spec, so not really ideal. |
miketaylr
pushed a commit
that referenced
this pull request
Nov 5, 2012
Fixed rotation in Moz/WebKit and corrected PageVisibility check
|
I went ahead and deployed it to the production site. The word-clipping is kind of weird. Can you create an open issue in our tracker so we can maybe try to fix it later on? thx. |
|
Thank you Mr. Taylor. Issue reported: #245 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also edited demo description and a bit of code tidy-up.
A note about the rotation fix - I had to make each character be an individual inline-block span. This removed whitespace so I fixed that with white-space:pre-wrap. However, this now puts line-breaks in the middle of words rather than the end. If we can live with that, it's ready to publish. Would be better if someone knew how to fix it, though...