Fix macOS compatibility and reenable CI tests #2490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattHag
force-pushed
the
fix_mac_tests
branch
2 times, most recently
from
cf8a75e to
c7dcc73
Compare
|
@pfps Ready. Upcoming changes enable more code to have module level units tests without mocks and without dependencies on actual I/O. |
Tests fail on macOS, enable them when unit tests are refined to only test the module without dependencies.
MattHag
changed the title
MattHag
changed the title
|
This change is crucial to support macOS again. Without this change the support is broken by recent changes with a dbus import. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #1244