Refactor: Completely remove UnsortedNamedInts #2656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify the code by removing this unnecessary class. Replace with default NamedInts implementation. Related pwr-Solaar#2273
|
I think the non-sorted version was at least at one time needed to get ordering of options in the UI correct so this PR needs to be checked to ensure that it does not change the UI. |
|
Can be, altough it sounds counterintuitive. If some natural order should be enforced, then it's better to add an explicit function that does that. |
|
As I remember, the order doesn't correspond to any sorting. It is just the order in which the items are added to the collection. But I'll have to check out how the UI works for several settings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the code by removing this unnecessary class. Replace with default NamedInts implementation.
Related #2273