Custom logger #2664
Draft
Custom logger #2664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement logger that internally checks if log level is enabled. Thus, unnecessary log message computation costs are avoid, when logging is disabled and logging code can be cut in half. Related pwr-Solaar#2663
MattHag
force-pushed
the
custom_logger
branch
from
36b6714 to
d4c412c
Compare
|
@pfps |
|
Yes, good idea. There is currently some weirdness going on with logging that I have seen occasionally. Some logging messages appear to be generated using some sort of default settings. I expect that this is another effect of how Python does module initialization. With any luck the changes here might be able to fix this weirdness. |
|
Great, then I just wait for the open changes to be merged and then I'll remove several hundred code lines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.