Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test parse args #2725

Merged
merged 2 commits into from
Jan 1, 2025
Merged

Unit test parse args #2725

merged 2 commits into from
Jan 1, 2025

Conversation

MattHag
Copy link
Collaborator

@MattHag MattHag commented Dec 23, 2024

No description provided.

@MattHag MattHag force-pushed the unit_tests branch 2 times, most recently from 8bbbeeb to a803c96 Compare December 26, 2024 11:44
@MattHag MattHag requested a review from pfps December 26, 2024 12:59
@MattHag
Copy link
Collaborator Author

MattHag commented Dec 26, 2024

This should be quite safe to merge

Copy link
Collaborator

@pfps pfps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Can this be merged before 2660?

@MattHag
Copy link
Collaborator Author

MattHag commented Jan 1, 2025

Yes, just merge it. The changed files don't seem to overlap.

@pfps pfps merged commit 8a0fc13 into pwr-Solaar:master Jan 1, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants