Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS: Add support for Bluetooth devices #2730

Merged
merged 4 commits into from
Jan 1, 2025

Conversation

MattHag
Copy link
Collaborator

@MattHag MattHag commented Dec 27, 2024

Use hidapi on macOS to communicate with Logitech peripherals connected via Bluetooth. This brings macOS device support on the same level as Linux.

Tested with MX Keys and MX Master 3S.

Fixes #2729

@MattHag MattHag force-pushed the mac_bluetooth_support branch from 0947080 to 7f6215a Compare December 27, 2024 00:05
@MattHag MattHag mentioned this pull request Dec 27, 2024
@MattHag MattHag force-pushed the mac_bluetooth_support branch 3 times, most recently from 353bae3 to 55f6e9d Compare December 27, 2024 01:10
Copy link
Collaborator

@pfps pfps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I can't test it. Have you tested out the CLI with this change?

@MattHag MattHag force-pushed the mac_bluetooth_support branch from a5c45e3 to 0e6e712 Compare January 1, 2025 15:54
@MattHag
Copy link
Collaborator Author

MattHag commented Jan 1, 2025

Looks fine now. The endian needs to be little here.

@pfps
Copy link
Collaborator

pfps commented Jan 1, 2025

OK. Can you create something for Release_Notes.md and any changes needed for documentation and add to this PR?

@MattHag
Copy link
Collaborator Author

MattHag commented Jan 1, 2025

Okay

Use hidapi on macOS to communicate and configure Logitech peripherals
connected via Bluetooth. This brings macOS device support on the same
level as Linux. However, some rules might not be supported yet on macOS.

Tested with MX Keys and MX Master 3S.

Fixes pwr-Solaar#2729
Warning about missing udev rules do not apply to macOS.

Related pwr-Solaar#2729
@MattHag MattHag force-pushed the mac_bluetooth_support branch from 0e6e712 to 958acb9 Compare January 1, 2025 16:48
@MattHag
Copy link
Collaborator Author

MattHag commented Jan 1, 2025

Added release notes for next Solaar version 1.15

@pfps
Copy link
Collaborator

pfps commented Jan 1, 2025

OK, merging.

@pfps pfps merged commit 800d349 into pwr-Solaar:master Jan 1, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

macOS: Add support for Bluetooth devices
2 participants