Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch workflow to r2u #109

Merged
merged 1 commit into from
Jun 26, 2024
Merged

switch workflow to r2u #109

merged 1 commit into from
Jun 26, 2024

Conversation

s3alfisc
Copy link
Member

@s3alfisc s3alfisc commented Jun 25, 2024

  • Switches the github action to r2u, which allows to install pre-built binaries of R packages on Linux. I use this for pyfixest and it saves a massive amount of time in the CI runs, as fwildclusterboot / other R packages do not need to be compiled from scratch.
  • Also, it still installs rwolf in the pyfixest wfl, which depends on fwildclusterboot and is also no longer on CRAN. So maybe it fixes Github Actions fail due to inability to install fwildclusterboot #108 temporarily =)

@s3alfisc
Copy link
Member Author

Seems to install fwildclusterboot in no time @amichuda! 🎉

@s3alfisc s3alfisc requested a review from amichuda June 25, 2024 21:47
@amichuda
Copy link
Collaborator

amichuda commented Jun 26, 2024

This looks great, but does it download the newest version of fwildclusterboot? Or is fwildclusterboot finished with development, so it's okay to install an older copy?

But if it works for pyfixest and other projects, then I say MERGE!

@s3alfisc
Copy link
Member Author

Yes, it installs the most recent fwildclusterboot version. So merged! =)

@s3alfisc s3alfisc merged commit fd72d39 into main Jun 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Github Actions fail due to inability to install fwildclusterboot
2 participants