Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thickness of Atomic columns at the edges of the potential images is fixed #640

Merged
merged 9 commits into from
Mar 28, 2024

Conversation

shinjandutta
Copy link
Contributor

  1. Moved up the code for calculate_correlation_array so as to calculate zone axes without the structure factor calculations in CrystalACOM.py
  2. Changed the code for generate_projected_potential in Crystal.py to fix the issue of varying thicknesses of the atomic columns in the generated potential images.

@cophus
Copy link
Member

cophus commented Mar 28, 2024

Code looks good - we double checked the modifications to orientation plan generation.

Copy link
Member

@cophus cophus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Projected potentials should be far more accurate now.

@cophus cophus merged commit 8b1fdbf into py4dstem:dev Mar 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants