Update digital_dark_field.py #688
Conversation
Radius filtering separated as function, and radius-azimuth imaging added as separate function
fixed minor errors
There was a problem hiding this comment.
Hi @maclariz - thanks for the PR and sorry for the delay. Please see the comments - I've requested two small docstring edits and one code edit for azimuthal ranges spanning a branchcut. Happy to get this pulled in once that's all squared - cheers :)
|
Now updated. Initially failed on code style but has been run through black and should now pass. |
|
Hi @maclariz - i've just pushed commits updating the black formatting so that the PR will pass the linter. This adds changes to a number of other files that were not passing linting, which looks like it has to do with a version update to black. Sorry about that and please don't worry about the other files elsewhere in the package that are updated - this is all black formatting changes. Aside from my branchcut comment, all looks good to me now. I see you've marked the patch as a draft, so I'll wait on merging until I hear otherwise from you. |
| np.where( | ||
| np.logical_or( | ||
| radial_filtered_points_array[:, 6] < phi0, | ||
| radial_filtered_points_array[:, 6] >= phi1, | ||
| ) |
There was a problem hiding this comment.
this still does not handle the branchcut issue (i.e. for data conditioned such that phi is e.g. in the range [0,360], you can't specify a range like [350,10] i.e. [-10,10] with this code). Let's call this is a quality-of-life / interface issue and you can decide if you want to update this now or later at your discretion; for now I'm ok pulling the code in if you're ok with this small interface issue
Radius filtering separated as function, and radius-azimuth imaging added as separate function