Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add permissions to publish #111

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Fix: add permissions to publish #111

merged 1 commit into from
Feb 26, 2024

Conversation

lwasser
Copy link
Member

@lwasser lwasser commented Feb 26, 2024

https://packaging.python.org/en/latest/guides/publishing-package-distribution-releases-using-github-actions-ci-cd-workflows/#defining-a-workflow-job-environment i'm not actually sure this is the right location for these permissions. or how to test. but i can ask someone in our slack to review?? or do you know @willingc i've not had to setup such permissions before but i've also not published using trusted publisher before i've always used a token.

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.64%. Comparing base (ef85f62) to head (700d108).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #111   +/-   ##
=======================================
  Coverage   41.64%   41.64%           
=======================================
  Files           4        4           
  Lines         461      461           
  Branches       74       74           
=======================================
  Hits          192      192           
  Misses        268      268           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lwasser lwasser merged commit 0d83fe3 into main Feb 26, 2024
5 checks passed
@lwasser lwasser deleted the lwasser-patch-1 branch March 11, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant