Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #476
simple enough - just passing the production env to the language building step.
edit: no longer true
changes the production baseurl to be the absolute path rather than the full URL - should be same behavior when deployed, but when testing locally it otherwise would have sent you to the live site rather than the local version.since this session is intended for deployment, and in deployment we are under the
python-package-guide/
path, when previewing this you would need to move the build output from_build/html
to_build/html/python-package-guide
(if you are e.g. launchinghttp-server
from_build/html
). this shoudln't be a problem in practice since you shouldn't need to directly preview the production build all that often, and thedocs-live-lang
/s
envs are for development.Since sphinx uses
html_baseurl
and we were overloading it, split out the lang selector base path in to a different variable.