-
-
Notifications
You must be signed in to change notification settings - Fork 588
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
I3769 kolzenberg2020 (Another option for the SEI growth) (#4394)
* Implementing Kolzenberg2020 model as another sei option * Implementing Kolzenberg2020 model as another sei option * Add .mypy_cache to .gitignore * Tunnelling limited has been added for SEI growth * change model's name * Citation name also changed * Citation name also changed * fix failing test * make SEI single layer only * Some test have been added for the new sei models * Bugs in test fixed, pybamm.sign(j) was not passed in dfn test so changed to logic operation * style: pre-commit fixes * fix failing tests * remove some further instances of inner & outer SEI * shorten comment * fix failing tests * switch examples to IDAKLU solver for robustness * fix typo with SEI OCP * revert to U_SEI = 0.4 V, except O'Kane2022 where beta_inner = 0 * change U_SEI in example to avoid simulation to break (replicates old parameters) * update CHANGELOG (and sort older entries) * remove duplicated entry from CHANGELOG * Update src/pybamm/models/submodels/interface/sei/sei_growth.py * revert some parameter changes as suggested by Simon * reduce SEI diffusivity to 2 significant digits (used to be 16) * capitalize the first letter * Capitalizing first letter of the parameters' names * Deleted the file * Update .gitignore Co-authored-by: Eric G. Kratz <[email protected]> * Update tests/unit/test_citations.py Co-authored-by: Eric G. Kratz <[email protected]> * Change log changed * Change log changed --------- Co-authored-by: Ferran Brosa Planella <[email protected]> Co-authored-by: Valentin Sulzer <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Eric G. Kratz <[email protected]>
- Loading branch information
1 parent
ddf6aa8
commit 82b1aae
Showing
14 changed files
with
183 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 3 additions & 2 deletions
5
tests/integration/test_models/test_full_battery_models/test_lithium_ion/test_dfn.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters