-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Host docs to readthedocs #14
Conversation
Docs are building here : https://pybamm-eis.readthedocs.io/en/latest/ |
awesome, thanks! just need to fix conflicts with the optional dependencies (literally merged #12 just as this opened) let's merge this and worry about making it pretty later. can you also update the readme to point to the docs? |
Thanks for adding the tests @rtimms, so sorry that it took me more time than expected. |
@@ -1,8 +1,11 @@ | |||
# PyBaMM EIS | |||
PyBaMM EIS rapidly calculates the electrochemical impedance of any battery model defined using PyBaMM. | |||
|
|||
PyBaMM EIS rapidly calculates the electrochemical impedance of any battery model defined using PyBaMM, see [the documentation](https://pybamm-eis.readthedocs.io/en/latest/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great, thanks, @arjxn-py ! |
Hosts documentation on
readthedocs
.Should fix #10