Skip to content

Fix GraalPy version parsing on dev builds #5609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 9, 2025

Conversation

msimacek
Copy link
Contributor

@msimacek msimacek commented Apr 9, 2025

I want to run pybind11 tests in our CI and dev builds have -dev suffix in the version.
I also unskipped a test that was previously broken due to the capsule name comparisons, but pybind11 has since moved away from doing those comparisons altogether.

@rwgk
Copy link
Collaborator

rwgk commented Apr 9, 2025

but pybind11 has since moved away from doing those comparisons altogether.

Do you think that was #5580?

@msimacek
Copy link
Contributor Author

msimacek commented Apr 9, 2025

Yes

@rwgk rwgk merged commit 708ce4d into pybind:master Apr 9, 2025
75 checks passed
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Apr 9, 2025
@rwgk rwgk removed the needs changelog Possibly needs a changelog entry label Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants