Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary fix for #82 #83

Merged
merged 3 commits into from
Jan 14, 2017
Merged

Temporary fix for #82 #83

merged 3 commits into from
Jan 14, 2017

Conversation

tokejepsen
Copy link
Member

Workaround for index.data(model.Object) not returning the correct object.

I'm running out of the dev time to solve this problem, so I thought I would contribute with some code that works for now.

@mottosso
Copy link
Member

Hey Toke, remind me again why it was important for index.data(model.Object) to return the correct object? By correct, you mean the actual Instance object as opposed to a plain list.

@tokejepsen
Copy link
Member Author

This is so we can work with the Instance object in callbacks.

@mottosso
Copy link
Member

Ah yes. Was there an issue for this?

@tokejepsen
Copy link
Member Author

#82

@mottosso
Copy link
Member

Perfect, thanks!

Ok, then I think I'm with you in that it isn't perfect but addresses an immediate problem.

If you version this up, I'll make a new release.

@tokejepsen
Copy link
Member Author

Ok, this is versioned up :)

@mottosso
Copy link
Member

Thank you. :)

@mottosso mottosso merged commit b1737db into pyblish:master Jan 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants