Avoid storing references to Certificates (#12028)

Its asymmetric with the read path, which owns the value, and thus woudl need to change for our GAT API.
pyca · Nov 24, 2024 · d3403c0 · d3403c0
1 parent 3452160
commit d3403c0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/rust/cryptography-x509/src/pkcs7.rs b/src/rust/cryptography-x509/src/pkcs7.rs
@@ -41,7 +41,7 @@ pub struct SignedData<'a> {
     pub certificates: Option<
         common::Asn1ReadableOrWritable<
             asn1::SetOf<'a, certificate::Certificate<'a>>,
-            asn1::SetOfWriter<'a, &'a certificate::Certificate<'a>>,
+            asn1::SetOfWriter<'a, certificate::Certificate<'a>>,
         >,
     >,
 

diff --git a/src/rust/src/pkcs7.rs b/src/rust/src/pkcs7.rs
@@ -52,7 +52,7 @@ fn serialize_certificates<'p>(
 
     let raw_certs = py_certs
         .iter()
-        .map(|c| c.raw.borrow_dependent())
+        .map(|c| c.raw.borrow_dependent().clone())
         .collect::<Vec<_>>();
 
     let signed_data = pkcs7::SignedData {
@@ -211,7 +211,7 @@ fn sign_and_serialize<'p>(
     let mut digest_algs = vec![];
     let mut certs = py_certs
         .iter()
-        .map(|p| p.raw.borrow_dependent())
+        .map(|p| p.raw.borrow_dependent().clone())
         .collect::<Vec<_>>();
 
     let ka_vec = cryptography_keepalive::KeepAlive::new();
@@ -288,7 +288,7 @@ fn sign_and_serialize<'p>(
         if !digest_algs.contains(&digest_alg) {
             digest_algs.push(digest_alg.clone());
         }
-        certs.push(cert.raw.borrow_dependent());
+        certs.push(cert.raw.borrow_dependent().clone());
 
         signer_infos.push(pkcs7::SignerInfo {
             version: 1,