Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancements to cuda array creation #19

Open
wants to merge 37 commits into
base: cuda_main_temp
Choose a base branch
from
Open

Enhancements to cuda array creation #19

wants to merge 37 commits into from

Conversation

bauom
Copy link
Collaborator

@bauom bauom commented Sep 5, 2023

A copy PR from pyccel#1236

For now in copy_CudaArray_Data the cudaMemcpyKind field of cudaMemcpy is hardcoded, this PR aims to make it so that field can be deduced from the variable's memory location and the current context of the function, as well as other fixes to make array creation in cuda easier.

  • Fixes compilation issues caused by the previous cuda_memcopy PR.
  • Raise an error when creating a Host array in Device function.
  • Create temporary variable when using numpy.array, cuda.array, cupy.array calls as arguments.

Pinkyboi and others added 30 commits November 18, 2022 13:02
@Pinkyboi
Add cudaMemcpyKind enum and fix typo in printing
4ab2e9f
@Pinkyboi
Merge branch 'cuda_main_temp' into cuda_memcopy
6057987
@Pinkyboi
Addition of context in array creation
69cb9d8
@Pinkyboi
Choose context using decorators
77b25a0
@Pinkyboi
Add cuda to_host and to_device
521d199
@Pinkyboi
Raise error when creating host array from kernel
ca9c7d1
@Pinkyboi
Create temporary variables when using numpy/cuda/cupy array as arg
938c732
@Pinkyboi
Add docstring to CudaToHost, CudaToDevice and CudaGrid
423571a
@Pinkyboi
Add test for cuda.to_device and cuda.to_host
7a703ae
@Pinkyboi
Remove numba functions from cudaext
f4d773b
@Pinkyboi
Merge branch 'cuda_main_temp' into cuda_memcopy
07adae4
@Pinkyboi
Split test to_host and to device
cb5c4cc
@EmilyBourne
Try reinstall
c0d4d32
@Pinkyboi
Add docstring for memory_location and current_context
4905573
@Pinkyboi
Use f-string in copy_CudaArray_Data
c427bb5
@Pinkyboi
Disable missing docstring and add missing final new line is ccuda tests
b4e5670
@Pinkyboi
Merge with cuda_main_temp
b58fb7a
@Pinkyboi
Use f-string in memcpy_kind
de6dc5c
@Pinkyboi
Try to fix django not configured pylint error
bb1dbba
@Pinkyboi
Remove disable=django-not-configure
41fa424
@Pinkyboi
Merge branch 'cuda_main_temp' into cuda_memcopy
f0330fb
@Pinkyboi
Merge branch 'cuda_main_temp' into cuda_memcopy
0f0a1fc
@Pinkyboi
Revert change on action.yml
9ea3abf
@Pinkyboi
Separate and / or with parentheses
bec781c
@Pinkyboi
Use get to check if array's memory location
6f16b4e
@Pinkyboi
Change CudaGrid doc string
8b89bba
@Pinkyboi
Use tuple instead of list for variable
b8643d2
@Pinkyboi
Add current_context to variable in _infere_type
38b2d10
@Pinkyboi
Put current context check in _assign_lhs_variable
4a8fab5
@Pinkyboi
Merge branch 'cuda_main_temp' into cuda_memcopy
7b099cc
@bauom bauom requested a review from EmilyBourne as a code owner September 5, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmilyBourne EmilyBourne Awaiting requested review from EmilyBourne EmilyBourne is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bauom @Pinkyboi @EmilyBourne