use requests.structures.CaseInsensitiveDict directly #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 26, 2021
Closed
adehad
force-pushed
the
feature/replace_inhouse_CaseInsensitiveDict
branch
from
5206606
to
f8517a2
Compare
studioj
approved these changes
Jul 21, 2021
studioj
added
Status: Ready
delete-merged-branch
bot
deleted the
feature/replace_inhouse_CaseInsensitiveDict
branch
ssbarnea
added
bug
and removed
chore
Status: Ready for Merge
svermeulen
pushed a commit
to svermeulen/jira
that referenced
this pull request
Oct 31, 2021
* use requests.structures.CaseInsensitiveDict directly * add tests for attachment using filename
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to replace #976 and #877 - as both of these reports had errors when attaching a file using a filename a test case has been added for that too.
Not sure why an in-house implementation was used back in the day, but
requestsis now a well established library I think it is safe to make the transition now.