Fixes #966 - Use verify parameter in requests #992
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SSL certificate verification was being done even when 'verify' was set to False. Now the parameter is explicitly passed to the request, avoiding this bug.
looks like the maintainers want to have the ci system back up and running before agreeing to any new merges. if you want to contribute to get yr pr through have a look here => #896 |
|
I am running into this issue as well. Please fix. |
if you want to contribute have a look here => #896 |
adehad
added
bug
Status: Ready
|
@jserafim please update your branch with latest master changes |
|
Closing due to lack of updates from @jserafim |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSL certificate verification was being done even when
verifywas set toFalse.Now the parameter is explicitly passed to the request, avoiding this bug.