Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore twine check #186

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Restore twine check #186

merged 1 commit into from
Jan 28, 2025

Conversation

Viicos
Copy link
Member

@Viicos Viicos commented Jan 28, 2025

Now works with the new 6.1.0 release.

Now works with the new 6.1.0 release.
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.71%. Comparing base (9983083) to head (6069ab5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #186   +/-   ##
=======================================
  Coverage   88.71%   88.71%           
=======================================
  Files          13       13           
  Lines        2207     2207           
  Branches     2207     2207           
=======================================
  Hits         1958     1958           
  Misses        153      153           
  Partials       96       96           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9983083...6069ab5. Read the comment docs.

Copy link

codspeed-hq bot commented Jan 28, 2025

CodSpeed Performance Report

Merging #186 will degrade performances by 10.14%

Comparing Viicos:restore-twine (6069ab5) with main (9983083)

Summary

❌ 1 regressions
✅ 72 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
sentence_jiter_iter 7.3 µs 8.1 µs -10.14%

Copy link
Collaborator

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@davidhewitt davidhewitt merged commit 11ef20f into pydantic:main Jan 28, 2025
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants