Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(formatter): check if expression contains await #944

Merged
merged 14 commits into from
Mar 31, 2025
Merged

feat(formatter): check if expression contains await #944

merged 14 commits into from
Mar 31, 2025
+80 −0

Conversation

Sbargaoui
Copy link
Contributor

@Sbargaoui Sbargaoui commented Mar 21, 2025 •
edited by alexmojaki
Loading

Closes #942

@Sbargaoui Sbargaoui force-pushed the fix/add-warning-for-async-contexts branch from 6d4581a to 92d302a Compare March 21, 2025 14:40
@Sbargaoui Sbargaoui marked this pull request as draft March 21, 2025 15:26
@Sbargaoui Sbargaoui force-pushed the fix/add-warning-for-async-contexts branch 2 times, most recently from d8ad096 to b468638 Compare March 21, 2025 15:30
@codecov Codecov
Copy link

codecov bot commented Mar 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@Sbargaoui Sbargaoui force-pushed the fix/add-warning-for-async-contexts branch from b468638 to 8ef2655 Compare March 21, 2025 15:39
@Sbargaoui Sbargaoui force-pushed the fix/add-warning-for-async-contexts branch from 8ef2655 to 66ee850 Compare March 21, 2025 15:43
@Sbargaoui Sbargaoui marked this pull request as ready for review March 21, 2025 15:47
@Sbargaoui Sbargaoui mentioned this pull request Mar 21, 2025
Closed
alexmojaki
alexmojaki reviewed Mar 21, 2025
View reviewed changes
@Sbargaoui Sbargaoui force-pushed the fix/add-warning-for-async-contexts branch from 8d21c8a to 2ea780b Compare March 25, 2025 12:20
alexmojaki
alexmojaki reviewed Mar 25, 2025
View reviewed changes
@Sbargaoui Sbargaoui marked this pull request as draft March 25, 2025 15:25
@Sbargaoui Sbargaoui force-pushed the fix/add-warning-for-async-contexts branch 3 times, most recently from 6b0b5f3 to d7ef318 Compare March 25, 2025 15:58
@Sbargaoui Sbargaoui force-pushed the fix/add-warning-for-async-contexts branch from d7ef318 to d6f6c9f Compare March 25, 2025 16:09
@Sbargaoui Sbargaoui marked this pull request as ready for review March 25, 2025 16:17
alexmojaki
alexmojaki reviewed Mar 26, 2025
View reviewed changes
alexmojaki
alexmojaki reviewed Mar 26, 2025
View reviewed changes
alexmojaki
alexmojaki reviewed Mar 26, 2025
View reviewed changes
@Sbargaoui Sbargaoui force-pushed the fix/add-warning-for-async-contexts branch from 402a41b to bfb3be5 Compare March 30, 2025 17:26
alexmojaki
alexmojaki reviewed Mar 31, 2025
View reviewed changes
alexmojaki
alexmojaki approved these changes Mar 31, 2025
View reviewed changes
Copy link
Contributor

@alexmojaki alexmojaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@alexmojaki alexmojaki enabled auto-merge (squash) March 31, 2025 10:40
@alexmojaki alexmojaki merged commit b2996f1 into pydantic:main Mar 31, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmojaki alexmojaki alexmojaki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SyntaxError when using 'await' expressions inside f-strings
2 participants
@Sbargaoui @alexmojaki