Change Agent.is_?_node() to use TypeIs instead #1622
+23
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small change to improve some ergonomics of the
Agent.is_*_node()
utility functions.This stems from wanting to do something if it is an AgentNode (but not necessarily one of the concrete node types
Since there is no
Agent.is_agent_node()
, it is not as easy to check the inverse case (i.e. when usingAgent.iter
). The only way to this currently is to useisinstance(node, End)
, which will narrow for the inverse case, but requires importingEnd
from pydantic_graph.As an example:
It looks like changing the signature of the other functions is inconsequential, but I guess it's consistent...
I imagine this is expected behavior anyways.