Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make checksum calculation more descriptive #293

Merged
merged 1 commit into from
Mar 3, 2025
Merged

Make checksum calculation more descriptive #293

merged 1 commit into from
Mar 3, 2025

Conversation

eumiro
Copy link
Contributor

@eumiro eumiro commented Mar 2, 2025

This PR just improved the readability of cyclic checksum calculations using itertools.cycle for repetitive factors.

yezz123
yezz123 approved these changes Mar 3, 2025
View reviewed changes
Copy link
Collaborator

@yezz123 yezz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@yezz123 yezz123 merged commit 1da2a1c into pydantic:main Mar 3, 2025
10 checks passed
@eumiro eumiro deleted the cycle-checksum branch March 3, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yezz123 yezz123 yezz123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eumiro @yezz123