-
-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Adapt benchmarks to use codspeed
#741
Conversation
Co-authored-by: Hameer Abbasi <[email protected]>
Co-authored-by: Hameer Abbasi <[email protected]>
Co-authored-by: Hameer Abbasi <[email protected]>
for more information, see https://pre-commit.ci
Co-authored-by: Hameer Abbasi <[email protected]>
CodSpeed Performance ReportMerging #741 will not alter performanceComparing Summary
Benchmarks breakdown
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of comments. Nice work overall!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changes -- otherwise LGTM.
@hameerabbasi Regarding:
It's not working the way I did it on this commit. But locally I did something else: I put them inside a |
For seed, let's unify it. For density, we can leave it constant in each file where it's constant; and change it where it should be changed. |
What does this mean? set just one value for all the tests, on all the files? Set the value on |
Set one value for everything in some central place. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One final change and we should be good to go. The changes discussed out-of-band can take place on this PR or a follow-up, as you wish.
I'll do the out-of-band changes on another PR if that's fine with you then. |
What type of PR is this? (check all applicable)
Related issues
Checklist
Please explain your changes below.
Adapted benchmarks from original file
benchmark_coo.py
that was used to benchmark withasv
. Now benchmarking withcodspeed
.