-
-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Modified index and slice tests in order to vary ranks #743
Conversation
CodSpeed Performance ReportMerging #743 will not alter performanceComparing Summary
Benchmarks breakdown
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this looks excellent. Thanks for the work, @DeaMariaLeon! I've left some minor comments.
Thanks! This should auto-merge when CI passes. |
I tried to "acknowledge the performance issues" on codspeed, but I'm lacking the rights to do it.
It's just that the benchmark changed name, and codspeed "thinks" that it's missing. I think we need to fix this in order to merge the PR, as codspeed will block. @hameerabbasi |
What type of PR is this? (check all applicable)
Related issues
Checklist
Please explain your changes below.
Original benchmarks used fixed rank