Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Modified index and slice tests in order to vary ranks #743

Merged
merged 7 commits into from
Aug 13, 2024

Conversation

DeaMariaLeon
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • πŸͺ„ Feature
  • 🐞 Bug Fix
  • πŸ”§ Optimization
  • πŸ“š Documentation
  • πŸ§ͺ Test
  • πŸ› οΈ Other

Related issues

  • Related issue #
  • Closes #

Checklist

  • Code follows style guide
  • Tests added
  • Documented the changes

Please explain your changes below.

Original benchmarks used fixed rank

Copy link

codspeed-hq bot commented Aug 12, 2024

CodSpeed Performance Report

Merging #743 will not alter performance

Comparing DeaMariaLeon:bench3 (ec4dc36) with main (45cdc71)

Summary

βœ… 23 untouched benchmarks

πŸ†• 21 new benchmarks
⁉️ 5 (πŸ‘ 5) dropped benchmarks

Benchmarks breakdown

Benchmark main DeaMariaLeon:bench3 Change
πŸ†• test_index_fancy[side=100-rank=1] N/A 923.9 Β΅s N/A
πŸ†• test_index_fancy[side=100-rank=2] N/A 816.7 Β΅s N/A
πŸ†• test_index_fancy[side=100-rank=3] N/A 3.5 ms N/A
πŸ†• test_index_fancy[side=1000-rank=1] N/A 1.7 ms N/A
πŸ†• test_index_fancy[side=1000-rank=2] N/A 4.5 ms N/A
πŸ‘ test_index_fancy[side=100] 3.5 ms N/A N/A
πŸ†• test_index_fancy[side=500-rank=1] N/A 1.1 ms N/A
πŸ†• test_index_fancy[side=500-rank=2] N/A 1.9 ms N/A
πŸ†• test_index_scalar[side=100-rank=1] N/A 320 Β΅s N/A
πŸ†• test_index_scalar[side=100-rank=2] N/A 401.2 Β΅s N/A
πŸ†• test_index_scalar[side=100-rank=3] N/A 480.9 Β΅s N/A
πŸ†• test_index_scalar[side=1000-rank=1] N/A 322.2 Β΅s N/A
πŸ†• test_index_scalar[side=1000-rank=2] N/A 402.3 Β΅s N/A
πŸ‘ test_index_scalar[side=100] 481.2 Β΅s N/A N/A
πŸ†• test_index_scalar[side=500-rank=1] N/A 323.8 Β΅s N/A
πŸ†• test_index_scalar[side=500-rank=2] N/A 403.4 Β΅s N/A
πŸ‘ test_index_slice2[side=100] 1.5 ms N/A N/A
πŸ‘ test_index_slice3[side=100] 1.4 ms N/A N/A
πŸ†• test_index_slice[side=100-rank=1] N/A 519.1 Β΅s N/A
πŸ†• test_index_slice[side=100-rank=2] N/A 632 Β΅s N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Copy link
Collaborator

@hameerabbasi hameerabbasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this looks excellent. Thanks for the work, @DeaMariaLeon! I've left some minor comments.

benchmarks/test_benchmark_coo.py Outdated Show resolved Hide resolved
benchmarks/test_benchmark_coo.py Outdated Show resolved Hide resolved
@hameerabbasi hameerabbasi enabled auto-merge (squash) August 13, 2024 06:59
hameerabbasi
hameerabbasi previously approved these changes Aug 13, 2024
@hameerabbasi
Copy link
Collaborator

Thanks! This should auto-merge when CI passes.

@hameerabbasi hameerabbasi disabled auto-merge August 13, 2024 07:29
@hameerabbasi hameerabbasi enabled auto-merge (squash) August 13, 2024 07:44
@DeaMariaLeon
Copy link
Collaborator Author

I tried to "acknowledge the performance issues" on codspeed, but I'm lacking the rights to do it.
I'm talking about the report's note above:

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

It's just that the benchmark changed name, and codspeed "thinks" that it's missing. I think we need to fix this in order to merge the PR, as codspeed will block. @hameerabbasi

@hameerabbasi hameerabbasi disabled auto-merge August 13, 2024 08:10
@DeaMariaLeon DeaMariaLeon merged commit 847023e into pydata:main Aug 13, 2024
18 of 19 checks passed
@DeaMariaLeon DeaMariaLeon deleted the bench3 branch August 13, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants